[RF] Modernize RooFit code with static_range_cast and dynamic_range_cast#22662
Merged
Conversation
The `static_range_cast` and `dynamic_range_cast` are RooFit helper functions to iterate over polymorphic collections like `RooArgSet` and `RooArgList`. Using them instead of casting in a separate line makes the code more concise with fewer lines and throw-away temoprary variables.
Member
|
Just as a curiosity, how are these different from |
Contributor
Author
|
It's the same. Originally, I only had For now, I prefer to keep the RooFit code at |
Test Results 21 files 21 suites 3d 7h 26m 27s ⏱️ Results for commit 801f960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
static_range_castanddynamic_range_castare RooFit helper functions to iterate over polymorphic collections likeRooArgSetandRooArgList. Using them instead of casting in a separate line makes the code more concise with fewer lines and throw-away temoprary variables.